Failure metrics for input diagnostics #20933
Conversation
patrickmann
force-pushed
the
failureMetrics
branch
from
8966f4a to
f12ea58
Compare
|
Moved the metric code up into |
There was a problem hiding this comment.
I think we should add the metrics after the message.supportsFailureHandling()
method. I've looked at the implementations of this interface method and it looks like messages from the inputs here always return true. Even if we extend the diagnostics page one day to show detailed information from the indexing/processing failure index, hopefully we won't have a discrepancy in the amount of messages then.
graylog2-server/src/main/java/org/graylog/failure/FailureSubmissionService.java
Show resolved
Hide resolved
graylog2-server/src/main/java/org/graylog/failure/FailureSubmissionService.java
Show resolved
Hide resolved
I was thinking it preferable to show a failure count, even if the messages don't support failure handling. At least you have an indication that something is wrong. I get your point of avoiding a discrepancy in counts, but I'd still prefer to see the "true" failure count. If this becomes an issue, we can hopefully label the data appropriately on the UI so it is not confusing to the user. |
graylog2-server/src/main/java/org/graylog/failure/FailureSubmissionService.java
Outdated
Show resolved
Hide resolved
graylog2-server/src/main/java/org/graylog/failure/FailureSubmissionService.java
Outdated
Show resolved
Hide resolved
/nocl new feature
Relates to issue #20683
Adds meters for every input that experiences processing and/or indexing failures. The meter names are
org.graylog2.<input Id>.failures.indexingorg.graylog2.<input Id>.failures.processingThese metrics are available in Open and Enterprise, independent of configuring the Processing and Indexing Failure stream.